Add ShellCheck to fedora images #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is installed at runtime in podman which is not good[1]. Install it here so we can drop the dnf install there. Also update some timebombs, pasta is in stable now, tar is still broken in debian and IMA bug is also still not fixed in podman. [1] https://github.com/containers/podman/blob/f22f4cfe50f70fa5bf6d8be6d1e3a33ca9668568/contrib/cirrus/prebuild.sh#L54 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
@edsantiago I am out next week so maybe you can try these images in podman and remove the extra install there. |
|
Cirrus CI build successful. Found built image names and IDs:
|
|
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Sep 9, 2024
Minor bump. Fedora VMs now include ShellCheck, so we can remove the 'dnf install' at CI run time. Also, FWIW, Debian *vark are now at 1.12 (from 1.9) VMs built in containers/automation_images#385 Signed-off-by: Ed Santiago <santiago@redhat.com>
|
containers/podman#23899 has green CI. So, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is installed at runtime in podman which is not good[1]. Install it here so we can drop the dnf install there.
Also update some timebombs, pasta is in stable now, tar is still broken in debian and IMA bug is also still not fixed in podman.
[1] https://github.com/containers/podman/blob/f22f4cfe50f70fa5bf6d8be6d1e3a33ca9668568/contrib/cirrus/prebuild.sh#L54